Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #1972/08e7d700 backport][stable-7] lookup/secretsmanager_secret - fix issue with missing nested secret and on_missing=warn #1975

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Feb 14, 2024

This is a backport of PR #1972 as merged into main (08e7d70).

SUMMARY

Fixes #1781
The lookup was raising an error instead of a warning message

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lookup/secretsmanager_secret

…nd on_missing=warn (#1972)

lookup/secretsmanager_secret - fix issue with missing nested secret and on_missing=warn

SUMMARY

Fixes #1781
The lookup was raising an error instead of a warning message

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

lookup/secretsmanager_secret

Reviewed-by: Mandar Kulkarni <[email protected]>
Reviewed-by: Alina Buzachis
(cherry picked from commit 08e7d70)
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/d1b5b911610943a0bd1622276e593ccf

✔️ ansible-galaxy-importer SUCCESS in 5m 18s
✔️ build-ansible-collection SUCCESS in 14m 20s
✔️ ansible-test-splitter SUCCESS in 5m 26s
✔️ integration-amazon.aws-1 SUCCESS in 6m 42s
Skipped 43 jobs

@hakbailey hakbailey added this to the 7.4.0 milestone Feb 22, 2024
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Feb 28, 2024
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/5dead8df9e434199814bff2bb96e884a

✔️ ansible-galaxy-importer SUCCESS in 4m 39s
✔️ build-ansible-collection SUCCESS in 15m 46s
✔️ ansible-test-splitter SUCCESS in 6m 33s
✔️ integration-amazon.aws-1 SUCCESS in 5m 48s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit eabda39 into stable-7 Feb 28, 2024
37 of 40 checks passed
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-7/08e7d70079a5e7dc4aa1e7ec55484ed22d341f7f/pr-1972 branch February 28, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants